Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first 0 of opcache.jit only disables CPU-specific optimizations, not the Just-in-Time compiler itself #70

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Apr 10, 2023

https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.jit

The first '0' only disables the CPU-specific optimization, not the JIT.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #70 (6fa6edf) into main (c336cb9) will decrease coverage by 1.47%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #70      +/-   ##
============================================
- Coverage     56.63%   55.17%   -1.47%     
- Complexity       65       67       +2     
============================================
  Files             2        2              
  Lines           113      116       +3     
============================================
  Hits             64       64              
- Misses           49       52       +3     
Impacted Files Coverage Δ
src/Runtime.php 50.50% <0.00%> (-1.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann sebastianbergmann merged commit 906e02e into sebastianbergmann:main Apr 11, 2023
@sebastianbergmann sebastianbergmann changed the title Fix opcache.jit validation The first 0 of opcache.jit only disables CPU-specific optimizations, not the Just-in-Time compiler itself Apr 11, 2023
@joanhey joanhey deleted the fix-jit branch April 11, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants