-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for attachment property #335
Comments
So far there has been no demand for it and therefore no plans to implement it. Definitely makes sense though and I would look into it when I get the time. Honestly though, I have to say that this probably won't be the case until early next year. If this is too long for you, feel free to use |
Thanks for your reply ;) I'll have a look at how I'll set it up, and might propose a PR to implement this feature! |
If you have any questions, feel free to contact me here. I will try to answer them in a timely manner. |
# [3.2.0-develop.1](v3.1.1...v3.2.0-develop.1) (2022-01-03) ### Features * **Events:** Add `createAttachment` / `attachments` ([12a382f](12a382f)), closes [#335](#335)
🎉 This issue has been resolved in version 3.2.0-develop.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hey @sebbo2002, I see you added support for I haven't reported back yet, because I couldn't get it to work with |
AFAIK they do yes, looks like I made a mistake on my end then, will have a look and see if anything might need changes for Google Calendar 👌 |
Sounds good. Then I wait with the release (#339) until you have tested it with Google Calendar and given the okay. |
K just tested this, and I see it works when directly importing the |
Oh wow. And with filename it works? Thanks for your research. |
No, the presence of a file name or even the |
Maybe the embedding of files directly works? I thought I leave that out, because the feeds are really unattractive large, but if it does not work otherwise we should adjust that again. |
Might work, although I can imagine they'll strip that as well, on top of the the very undesirable fact that the calendar file might become huge as well :/ |
Are there any updates here? |
Not yet, haven't been able to investigate more because of other work. I honestly don't think that it's related to the implementation of this package, rather in the way that both Google Calendar as well as iCal treat calendar subscriptions, feels like they might be sanitizing attachments for security reasons. I'll see if I get some more time in the near future to investigate, but meanwhile I'd argue this issue is done, as the implementation works great when importing generated |
That makes sense. Then I'll mark this ticket as closed, then I can publish this within the next few days together with #340. If you find out anything in your investigation, feel free to let me know. |
🎉 This issue has been resolved in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi! I noticed the current
ICalEvent
andICalEventData
don't support theATTACH
property when creating an event throughcreateEvent
, as defined in the spec.Are there any plans to add support, or should we get an implementation running using the last property of
ICalEventData
?Thanks!
The text was updated successfully, but these errors were encountered: