-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attendee RSVP is not honoured when value is false #340
Labels
Comments
I can possibly take care of it tonight, thank you. |
github-actions bot
pushed a commit
that referenced
this issue
Jan 10, 2022
# [3.2.0-develop.2](v3.2.0-develop.1...v3.2.0-develop.2) (2022-01-10) ### Bug Fixes * **Attendee:** Print RSVP also if rsvp is set to false ([27e5166](27e5166)), closes [#340](#340)
🎉 This issue has been resolved in version 3.2.0-develop.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apologies for not raising this as a PR fix- I'll try and find time this week if you can't get their first.
For attendee if it's set to false then it isn't represented in the iCal object. This is due to the code at https://github.com/sebbo2002/ical-generator/blob/develop/src/attendee.ts#L548-L550
if (this.data.rsvp) { g += ';RSVP=' + this.data.rsvp.toString().toUpperCase(); }
Because the value is false, it doesn't enter this if loop. Instead this needs to check if the key is present and, presumably, that it's a boolean, and if so fall in and append the RSVP.
The text was updated successfully, but these errors were encountered: