-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug when scanning using unicast #324
Comments
🎉 This issue has been resolved in version 7.4.0-develop.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fix is on it's way. You get the errors as well if you set the second parameter in const result = await pyatv.find({}, true);
console.log(result.devices);
console.log(result.errors); Give it a try and let me know if that solves the problem. And thank you for the ticket, it was excellent. It contains everything I required. 👍🏼 |
Thanks for the fast response. Would it be possible to export the NodePyATVFindResponseObject interfcae, so I can reference that interface? |
I knew I had forgotten something. Fix is on its way... |
When will this be available in a prerelease version? |
🎉 This issue has been resolved in version 7.4.0-develop.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sorry, now it's there… |
# [7.4.0](v7.3.0...v7.4.0) (2024-08-04) ### Bug Fixes * Do not trigger "special" events when they are not received ([c63dfe6](c63dfe6)), closes [#326](#326) ### Features * Export `NodePyATVFindResponseObject` and `NodePyATVRequestOptions` ([c668148](c668148)), closes [#324](#324) * Support unicast scans ([2b25f7e](2b25f7e)), closes [#324](#324)
🎉 This issue has been resolved in version 7.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi, it's me again.
So on my homebridge-appletv-enhanced plugin I always had coming in a few issues regarding a specific error:
Now, I got my hand on verbose logs from a user who has these problems: maxileith/homebridge-appletv-enhanced#407 (you can read the original logs in the attatchment of this issue). In verbose log, my plugin prints debug messages from your library and therefore it is easy to dig into it.
So the user has configured the plugin in a way that it does unicast discovery: Your library then executes the following
atvscript
command:So far so good. However, the
atvscript
then returns instead of a single JSON line three lines with the individual JSONs which your library simply does not expext:So 2 of the 6 unicast scans were unsuccesful. The
atvscript
return a seperate json for each error and one single json for all successful scans. As the lib does not expect that it throws the following error:Position 1504 is the line break after the first JSON in line 1 of 3.
So what I basically need, is that the library does not throw an error and parses the successful scans correctly. On top I need a list of errors so that I can output that in my plugin. Would that be feasible?
A workaround I could imagine would be to do call the find method for each Host individually ...
Thanks in advance and thank you for the lib :)
The text was updated successfully, but these errors were encountered: