Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume event triggered even though the volume did not change #326

Closed
maxileith opened this issue Jul 11, 2024 · 4 comments
Closed

Volume event triggered even though the volume did not change #326

maxileith opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels

Comments

@maxileith
Copy link
Contributor

maxileith commented Jul 11, 2024

Hello,

it's me again. I have found another bug. I am currently implementing volume control in my homebridge plugin and noticed that a volume event with the value null is triggered even though the volume doesn't change.

[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [V] CustomPyATVInstance: [node-pyatv][5N] stdout: {"result": "success", "datetime": "2024-07-11T18:31:44.296098+02:00", "hash": "OuDG6g5iU::yzccTFvsr", "media_type": "music", "device_state": "playing", "title": "The Way You Make Me Feel", "artist": "Michael Jackson", "album": "Bad (25th Anniversary Edition)", "genre": "Pop", "total_time": 298, "position": null, "shuffle": "off", "repeat": "off", "series_name": null, "season_number": null, "episode_number": null, "content_identifier": null, "app": "Musik", "app_id": "com.apple.TVMusic"}
[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [V] CustomPyATVInstance: [node-pyatv][5N] > {"result": "success", "datetime": "2024-07-11T18:31:44.296098+02:00", "hash": "OuDG6g5iU::yzccTFvsr", "media_type": "music", "device_state": "playing", "title": "The Way You Make Me Feel", "artist": "Michael Jackson", "album": "Bad (25th Anniversary Edition)", "genre": "Pop", "total_time": 298, "position": null, "shuffle": "off", "repeat": "off", "series_name": null, "season_number": null, "episode_number": null, "content_identifier": null, "app": "Musik", "app_id": "com.apple.TVMusic"}
[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [V] CustomPyATVInstance: [node-pyatv][5N] No position value found in input ({"result":"success","datetime":"2024-07-11T18:31:44.296098+02:00","hash":"OuDG6g5iU::yzccTFvsr","media_type":"music","device_state":"playing","title":"The Way You Make Me Feel","artist":"Michael Jackson","album":"Bad (25th Anniversary Edition)","genre":"Pop","total_time":298,"position":null,"shuffle":"off","repeat":"off","series_name":null,"season_number":null,"episode_number":null,"content_identifier":null,"app":"Musik","app_id":"com.apple.TVMusic"})
[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [V] CustomPyATVInstance: [node-pyatv][5N] No powerState value found in input ({"result":"success","datetime":"2024-07-11T18:31:44.296098+02:00","hash":"OuDG6g5iU::yzccTFvsr","media_type":"music","device_state":"playing","title":"The Way You Make Me Feel","artist":"Michael Jackson","album":"Bad (25th Anniversary Edition)","genre":"Pop","total_time":298,"position":null,"shuffle":"off","repeat":"off","series_name":null,"season_number":null,"episode_number":null,"content_identifier":null,"app":"Musik","app_id":"com.apple.TVMusic"})
[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [V] CustomPyATVInstance: [node-pyatv][5N] No focusState value found in input ({"result":"success","datetime":"2024-07-11T18:31:44.296098+02:00","hash":"OuDG6g5iU::yzccTFvsr","media_type":"music","device_state":"playing","title":"The Way You Make Me Feel","artist":"Michael Jackson","album":"Bad (25th Anniversary Edition)","genre":"Pop","total_time":298,"position":null,"shuffle":"off","repeat":"off","series_name":null,"season_number":null,"episode_number":null,"content_identifier":null,"app":"Musik","app_id":"com.apple.TVMusic"})
[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [D] Apple TV Wohnzimmer Apple TV (AA:BB:CC:DD:EE:FF): event volume: null
[7/11/2024, 6:31:44 PM] [Apple TV Enhanced] [I] Apple TV Wohnzimmer Apple TV (AA:BB:CC:DD:EE:FF): Volume has been set to 0
@sebbo2002 sebbo2002 self-assigned this Jul 11, 2024
@sebbo2002 sebbo2002 added the bug Something isn't working label Jul 11, 2024
@sebbo2002 sebbo2002 mentioned this issue Jul 11, 2024
@maxileith
Copy link
Contributor Author

Damn. That was fast 💯

@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 7.4.0-develop.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebbo2002
Copy link
Owner

Haha, I do my very best. Hope that's already it.

github-actions bot pushed a commit that referenced this issue Aug 4, 2024
# [7.4.0](v7.3.0...v7.4.0) (2024-08-04)

### Bug Fixes

* Do not trigger "special" events when they are not received ([c63dfe6](c63dfe6)), closes [#326](#326)

### Features

* Export `NodePyATVFindResponseObject` and `NodePyATVRequestOptions` ([c668148](c668148)), closes [#324](#324)
* Support unicast scans ([2b25f7e](2b25f7e)), closes [#324](#324)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants