F601 - dictionary key repeated with different values

[guedou]

Another PR of the #1277 serie. It removes duplicated dictionary keys.

[codecov-io]

Codecov Report

Merging #1441 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   82.95%   82.96%   +<.01%     
==========================================
  Files         179      179              
  Lines       42230    42230              
==========================================
+ Hits        35032    35035       +3     
+ Misses       7198     7195       -3

Impacted Files	Coverage Δ
scapy/contrib/homeplugav.py	92.47% <ø> (ø)	⬆️
scapy/layers/bluetooth.py	86.54% <ø> (ø)	⬆️
scapy/utils.py	75.07% <ø> (ø)	⬆️
scapy/sendrecv.py	80.57% <0%> (-0.65%)	⬇️
scapy/layers/inet6.py	87.4% <0%> (-0.06%)	⬇️
scapy/asn1/ber.py	82.38% <0%> (+0.28%)	⬆️
scapy/automaton.py	76.34% <0%> (+0.55%)	⬆️
scapy/layers/tls/record.py	92.12% <0%> (+0.87%)	⬆️

[p-l-]

Why do you add noqa comments rather than removing (maybe commenting?) the duplicated keys which, anyway won't be used?

[guedou]

When noqa is used, it means that both keys are valid according to the specifications, or documents that I found. I thing it is better that commenting because it keeps the same code as today.

[p-l-]

The thing is when we leave two entries with the same key, we do not know which one will be chosen (this may change with different Python version). I think it would be cleaner to explicitly chose the value that will exist in the dictionary rather than letting the Python interpreter chose for us.

[guedou]

@p-l- I agree but I don't know which values should be kept =/

[guedou]

@p-l- what's your call on this PR?

[gpotter2]

The real issue is that MIBDict use a weirdo-inverted format that makes no sense.

To properly fix this, we need to fix what args MIBDict takes, and revert all keys/values

[guedou]

@gpotter2 can you explain what could be done here?

[guedou]

@gpotter2 @p-l- rebased and ready to be reviewed.

This is now as small PR.