-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse MIB storage format #1611
Conversation
745ab36
to
19ca268
Compare
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
===========================================
- Coverage 85.26% 75.16% -10.11%
===========================================
Files 179 125 -54
Lines 42143 29489 -12654
===========================================
- Hits 35935 22164 -13771
- Misses 6208 7325 +1117
|
da6d107
to
898394a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Could you add docstrings do the methods that you are modifying? Thanks!
898394a
to
d3530b1
Compare
Added some vague quite vague docstrings (I'm not 100% sure of each's function exact doings) |
d3530b1
to
7cb2efa
Compare
@gpotter2 Thanks! This will help us get a better understanding of the code. |
See #1441
This PR reverse the way MIB data is stored in scapy: it makes more sense to use the unique OID as key in the storage dictionaries, rather than its value, that can be a duplicate
I'm pretty sure this even improve speed, as we use
self[key]
less often.Warning: This PR has 2 breaking changes
conf.mib
)-
which was previously converted to_
(I.esha1-...
) will not be replaced anymore. This is the wanted usage, but not the one there used to be. (I’m open to a compatibility “- to _” function if necessary, but I’d rather move away from it)