Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install pre-release packages in tox environments #464

Merged

Conversation

joshuagl
Copy link
Collaborator

Fixes: #458

Description of the changes being introduced by the pull request:

  • Removes the argument to pip during tox environment setup which tells pip to install pre-release versions of packages.
  • Updates the lint tox environment to use latest (3.11) version of Python

Please verify and check that the pull request fulfils the following requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

When setting up tox environments do not instruct pip to install
pre-release versions of packages.

Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! LGTM.

FYI: We've already decided that this is a good idea a while ago:
theupdateframework/python-tuf#1350

@lukpueh lukpueh merged commit 1ffd043 into secure-systems-lab:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint fails on newest Python
2 participants