Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError for downloading Sample Types #2076

Open
kdp-cloud opened this issue Nov 27, 2024 · 6 comments
Open

NoMethodError for downloading Sample Types #2076

kdp-cloud opened this issue Nov 27, 2024 · 6 comments
Labels
Milestone

Comments

@kdp-cloud
Copy link
Collaborator

Accessing /sample_types/:id/download raises a NoMethodError:

A NoMethodError occurred in sample_types#download:

  undefined method `content_blob' for nil:NilClass

                          [asset_version.content_blob]
                                        ^^^^^^^^^^^^^
  lib/seek/content_blob_common.rb:15:in `download'
@kdp-cloud kdp-cloud added the bug label Nov 27, 2024
@kdp-cloud kdp-cloud added this to the 1.16.1 milestone Nov 27, 2024
@kdp-cloud kdp-cloud moved this to Backlog in SEEK 1.16.x Nov 27, 2024
@github-project-automation github-project-automation bot moved this to Requirements in DataHub Nov 27, 2024
@stuzart
Copy link
Member

stuzart commented Nov 28, 2024

there isn't a download action for sample_types, the download route is through the content-blob for the template, i.e sample_type/:id/content_blobs/:id/download

@stuzart
Copy link
Member

stuzart commented Nov 28, 2024

is the issue here that this information isn't available in the api json response ?

@kdp-cloud
Copy link
Collaborator Author

When you click the download button, it also raises that error. This looks like a proper bug!

@stuzart
Copy link
Member

stuzart commented Nov 29, 2024

OK. But I don't get a Download button for Sample types, just the Download link for a template which includes the content blob path

Is this something specific to DataHub or is there an example on https://testing.sysmo-db.org ?

Or could it be related to the sample type permission changes, giving a can_download? option ?

@stuzart
Copy link
Member

stuzart commented Nov 29, 2024

Oh - I've spotted it, in the list view 👍

image

@stuzart
Copy link
Member

stuzart commented Nov 29, 2024

would be good to fix this for 1.16.0 so updated the milestone

@stuzart stuzart modified the milestones: 1.16.1, 1.16.0 Nov 29, 2024
@stuzart stuzart moved this from Backlog to Ready in SEEK 1.16.x Dec 2, 2024
@kdp-cloud kdp-cloud moved this from Requirements to Merged in DataHub Dec 4, 2024
@kdp-cloud kdp-cloud moved this from Merged to Backlog in DataHub Dec 4, 2024
@stuzart stuzart modified the milestones: 1.16.0, 1.16.1 Dec 4, 2024
@stuzart stuzart moved this from Ready to Backlog in SEEK 1.16.x Dec 4, 2024
@stuzart stuzart removed the status in SEEK 1.16.x Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Status: No status
Development

No branches or pull requests

2 participants