-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download sampletype template is shown and available if can_download? is false #2084
Milestone
Comments
stuzart
added a commit
that referenced
this issue
Dec 2, 2024
stuzart
added a commit
that referenced
this issue
Dec 2, 2024
also a only once task to fix the previously updated permissions
stuzart
added a commit
that referenced
this issue
Dec 2, 2024
stuzart
added a commit
that referenced
this issue
Dec 3, 2024
stuzart
added a commit
that referenced
this issue
Dec 3, 2024
also a only once task to fix the previously updated permissions
stuzart
added a commit
that referenced
this issue
Dec 3, 2024
stuzart
added a commit
that referenced
this issue
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously the Template could always be downloaded if the sample type was visible, but since the introduction of permissions can_download? has been added as an option. As discovered with #2076 the download button is shown, but only if there is permissions, but the download link on the sample type view page is always shown and accessible if visible.
should also make sure and add tests that the action is blocked if can_download? is false.
There is a question of whether this separate permission is needed, as downloading the template doesn't reveal anything not already known.
The text was updated successfully, but these errors were encountered: