Sample Type and download permissions #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also a only once task to fix the previously updated permissions
kdp-cloud
reviewed
Dec 3, 2024
| def self.supports_extended_metadata? | ||
| false | ||
| end | ||
|
|
There was a problem hiding this comment.
Just a question. Does it support Extended Metadata now? Or is it not necessary anymore because it's an asset now?
There was a problem hiding this comment.
SampleTypes don't support EM. I didn't add this by the way, but just moved up the class out of the private area so I could group these overrides together
kdp-cloud
reviewed
Dec 3, 2024
| SampleType.includes(:policy).where.not(policy_id: nil).each do |sample_type| | ||
| policy = sample_type.policy | ||
| if policy.access_type == Policy::VISIBLE | ||
| policy.update_column(:access_type, Policy::ACCESSIBLE) |
There was a problem hiding this comment.
Again a question. Does a sample type need to be accessible in order to be able to download the template?
There was a problem hiding this comment.
Yes, because it goes throught the content blob controller it checks the permissions on the associated asset. There is an example here: https://testing.sysmo-db.org/sample_types/97
kdp-cloud
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override methods to prevent sample types being treated as a downloadable asset. This means it behaves more like Samples, Investigation, Studies and Assays, and the permission options don't include a Download option (however, the ACCESSIBLE access type is applied).
Also updated the upgrade task to apply ACCESSIBLE instead of VIEWABLE, and a new task to update the previously applied permissions.
Although unlikely to be the case, the Download template option isn't shown if viewable but not accessible.