Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker ARM64 builds with Docker Buildx #343

Closed
wants to merge 1 commit into from

Conversation

knorby
Copy link
Contributor

@knorby knorby commented May 6, 2022

I ran into this same issue, as your Docker release is only packaged for linux/amd64. It looks like your github actions are already setup to use docker buildx with multi-platform builds, so this PR just updates your docker build to package for linux/arm64 as well. I can't test your github actions too easily, but hopefully this quick change just works; I verified it locally, but buildx sometimes needs a bit more setup.

@asaf-erlich
Copy link
Contributor

The change looks good to me but unfortunately it only actually gets exercised on tag creation making it quite hard to test end-to-end:

on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'
- 'v[0-9]+.[0-9]+.[0-9]-[a-zA-Z0-9]+'

@asaf-erlich
Copy link
Contributor

@rikez do you know why the docker login test failed? https://github.com/segmentio/chamber/runs/6372395627?check_suite_focus=true

@asaf-erlich
Copy link
Contributor

@emmy-byrne-segment since you're more of an expert here do you know if we have any concerns with switching over to docker buildx in this PR? Would we prefer to rely on separate arm64 runners here instead for the arm64 build?

@emmy-byrne-segment
Copy link
Contributor

I think that it's fine to use buildx here because this is for the container versions and the executables are what need testing on different platforms.

However the dockerfile line here:

https://github.com/segmentio/chamber/blob/master/Dockerfile#L10

Is calling the makefile line here:

https://github.com/segmentio/chamber/blob/master/Makefile#L40

Which would use the amd64 executable and us publishing an an arm64 version of the container wouldn't change that.

The dockerfile would need to be changed to also build the correct excutable from the makefile based on the platform

@alecjacobs5401 alecjacobs5401 linked an issue May 24, 2022 that may be closed by this pull request
@kevcube kevcube mentioned this pull request May 31, 2022
@knorby
Copy link
Contributor Author

knorby commented Jun 6, 2022

Closing in favor of #348

@knorby knorby closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: linux/arm64 docker builds on dockerhub
3 participants