arm64 docker builds #348
arm64 docker builds #348
Conversation
kevcube
force-pushed
the
arm64_docker_builds
branch
from
93876ad
to
23057d8
Compare
|
includes @knorby's work |
| @@ -3,11 +3,12 @@ FROM golang:1.13-alpine AS build | |||
| WORKDIR /go/src/github.com/segmentio/chamber | |||
| COPY . . | |||
|
|
|||
| ARG TARGETARCH | |||
There was a problem hiding this comment.
this is a default arg of buildkit-based builds
|
@emmy-byrne-segment this should address this comment |
| @@ -8,6 +8,10 @@ ifndef VERSION | |||
| VERSION := $(shell git describe --tags --always --dirty="-dev") | |||
| endif | |||
|
|
|||
| ifndef TARGETARCH | |||
| TARGETARCH := $(shell arch) | |||
There was a problem hiding this comment.
An issue we might have here is that OS X reports arm64 but linux reports aarch64 when running this command on the same machine and arch.
since *nix varieties cannot agree here i think we need to make sure this is going to output exactly what we expect it to.
|
@emmy-byrne-segment I just made an extra name for the linux target so that it'll catch both arm64/aarch64; is this an acceptable solution? |
|
Thanks for picking this up, @kevcube! |
|
@kevcube that should work unless i am mistaken, thank you! Just checking on this dockerhub failure before we merge this |
|
Turns out thats working as expected because i forgot this was a fork and that test wont work on branches. Thank you again for the PR! Merging. |
Supersedes #343