-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): resolve aws sso profile issues by updating aws-sdk-go@v1.38 #377
Conversation
Could you folks please review when you get a chance? cc: @mckern @asaf-erlich @rikez I think adding something like renovatebot would help out a lot with automating these upgrades in the future :) |
8edb860
to
2e656b6
Compare
Is |
dependabot is certainly nice but it's not as configurable as renovatebot so I prefer the latter. To add renovatebot, it would be adding the bot to the repo and then merging the default PR that it generates. Perhaps dependabot for now would be easier to keep dependencies up to date? |
2e656b6
to
465a0af
Compare
cc: @alecjacobs5401 please re-review when time permits |
@nitrocode I approved the workflow runs and it looks like things aren't happy for go1.16 |
465a0af
to
6fff0f5
Compare
6fff0f5
to
996cef1
Compare
Ok, I tested on go 1.16 and only updated the aws-sdk-go and that seems to have fixed the issue. If I update to the latest aws-sdk-go, then it requires at least go 1.17 due to I was unable to test on 1.15 because it does not have an arm binary. Please see if the new changes build across the different versions. |
cc: @alecjacobs5401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for contributing this fix @nitrocode!
Thanks for merging @alecjacobs5401 ! What's the next step to get a new release out? I'd imagine it would be 2.12.1 since it's a bug fix. |
Oh I see this PR coming through #382 so looks like soon 🙏 |
@nitrocode I think we have a few things currently batched up so this might end up being a minor version bump. Should have a better answer/release for you by end of week |
Thank you for releasing 2.13.0!!! |
what
why
AWS_PROFILE
withaws sso
issuesreferences
commands
Before update
Replace was necessary in order to rungo get -u
After update
✗ rm -f chamber && make build ✗ AWS_PROFILE=test ./chamber list-services Service hello-world/secret