chore(deps): resolve aws sso profile issues by updating aws-sdk-go@v1.38

[nitrocode]

what

• Use latest github.com/aws/aws-sdk-go@v1.38

why

• Resolve AWS_PROFILE with aws sso issues

references

• Closes Issues with chamber and aws sso #376

commands

Before update

✗ AWS_PROFILE=test chamber list-services
Error: Failed to get secret store: SharedConfigErr: only one credential type may be specified per profile: source profile, credential source, credential process, web identity token, or sso

✗ go get -u github.com/aws/aws-sdk-go@v1.38

Replace was necessary in order to run go get -u

✗ go mod edit -replace gopkg.in/segmentio/analytics-go.v3=github.com/segmentio/analytics-go/v3@v3.2.1
✗ go mod tidy

After update

✗ rm -f chamber && make build
✗ AWS_PROFILE=test ./chamber list-services
Service
hello-world/secret

[nitrocode]

Could you folks please review when you get a chance?

cc: @mckern @asaf-erlich @rikez

I think adding something like renovatebot would help out a lot with automating these upgrades in the future :)

[asaf-erlich]

Is renovatebot preferred over github's dependabot which I'm more used to? Just found this: https://javascript.plainenglish.io/automate-dependency-updates-by-renovate-not-by-dependabot-6efddd549a3e . Happy to help the team turn dependabot on for now as I've done it for a bunch of our repos.

[nitrocode]

Is renovatebot preferred over github's dependabot which I'm more used to?

dependabot is certainly nice but it's not as configurable as renovatebot so I prefer the latter.

To add renovatebot, it would be adding the bot to the repo and then merging the default PR that it generates.
To add dependabot, it's just enabling the bot on the repo (as you know).

Perhaps dependabot for now would be easier to keep dependencies up to date?

[nitrocode]

cc: @alecjacobs5401 please re-review when time permits

[alecjacobs5401]

@nitrocode I approved the workflow runs and it looks like things aren't happy for go1.16

[nitrocode]

Ok, I tested on go 1.16 and only updated the aws-sdk-go and that seems to have fixed the issue.

If I update to the latest aws-sdk-go, then it requires at least go 1.17 due to x/sys@v0.1.0

I was unable to test on 1.15 because it does not have an arm binary.

Please see if the new changes build across the different versions.

[nitrocode]

cc: @alecjacobs5401

[alecjacobs5401]

LGTM - thanks for contributing this fix @nitrocode!

[nitrocode]

Thanks for merging @alecjacobs5401 ! What's the next step to get a new release out?

I'd imagine it would be 2.12.1 since it's a bug fix.

[nitrocode]

Oh I see this PR coming through #382 so looks like soon 🙏

[alecjacobs5401]

@nitrocode I think we have a few things currently batched up so this might end up being a minor version bump. Should have a better answer/release for you by end of week

[nitrocode]

Thank you for releasing 2.13.0!!!