Update Dockerfile to use go 1.20.4-alpine #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinr23
approved these changes
May 3, 2023
|
I don't have any particular problems with this but it's worth pointing out that this explicitly moves the base image from a floating Go revision (1.x) to a specific Go revision (1.x.x) and we (the maintainers) should be aware of that. I generally prefer specific versions for producing release artifacts, so I'm 👍🏻 on this but I want to make sure that doesn't go unnoticed by other maintainers. |
|
FWIW, this should be merged after #382. That adds Go 1.20.x into the test matrix. It may require merging |
mckern
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #378