Fix accumulated papercuts #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring struct literals with ordered parameters is "fine" but it's also brittle. We should use the struct field names to make intent crystal-clear.
Not a functional fix, but `go fix` flagged and replaced it, and who am I to argue with `go fix`?
The 3rd party package github.com/pkg/errors is no longer required to wrap errors. This was handled programmatically by the tool github.com/xdg-go/go-rewrap-errors and should be complete.
alecjacobs5401
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So,
chamberhas accumulated a number of papercuts over the years: small things, easy to overlook but that sting in the moment. Nothing that's going to completely halt operation, but will annoy you (read: me, Joe Sportsbar Average User) when you touch them. Here's a swing at fixing a few of these up in the hopes of further improving future maintenance:cmd/find_test.gogo:builddirectives format instead of deprecated+build: