Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accumulated papercuts #384

Merged
merged 4 commits into from
May 11, 2023
Merged

Fix accumulated papercuts #384

merged 4 commits into from
May 11, 2023

Commits on May 10, 2023

  1. Improve test readability for cmd/find_test.go 

    Declaring struct literals with ordered parameters is "fine" but it's
also brittle. We should use the struct field names to make intent
crystal-clear.
    @mckern
    mckern committed May 10, 2023
    Configuration menu
    Copy the full SHA
    acbe294 View commit details
    Browse the repository at this point in the history

  2. Update go:build directives

    @mckern
    mckern committed May 10, 2023
    Configuration menu
    Copy the full SHA
    35565b6 View commit details
    Browse the repository at this point in the history

  3. Use more concise iterator assignment 

    Not a functional fix, but `go fix` flagged and replaced it, and who am
I to argue with `go fix`?
    @mckern
    mckern committed May 10, 2023
    Configuration menu
    Copy the full SHA
    b153856 View commit details
    Browse the repository at this point in the history

  4. Use contemporary error wrapping 

    The 3rd party package github.com/pkg/errors is no longer required to
wrap errors. This was handled programmatically by the tool
github.com/xdg-go/go-rewrap-errors and should be complete.
    @mckern
    mckern committed May 10, 2023
    Configuration menu
    Copy the full SHA
    e032a23 View commit details
    Browse the repository at this point in the history