Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EventAttribute type #658

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Update EventAttribute type #658

merged 1 commit into from
Mar 31, 2023

Conversation

LCyson
Copy link
Contributor

@LCyson LCyson commented Mar 16, 2023

Describe your changes and provide context

This PR updates the affected EventAttribute fields from sei-protocol/sei-cosmos#195

Testing performed to validate your change

  • unit test
  • local test
  • pending testing on loadtest cluster and upgrade on devnet-3

LCyson
LCyson commented Mar 16, 2023
View reviewed changes
go.mod Outdated
@@ -269,10 +269,10 @@ require (
replace (
github.com/CosmWasm/wasmd => github.com/sei-protocol/sei-wasmd v0.0.1
github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0
github.com/cosmos/cosmos-sdk => github.com/sei-protocol/sei-cosmos v0.2.3
github.com/cosmos/cosmos-sdk => github.com/sei-protocol/sei-cosmos v0.2.4-0.20230315070856-3bc878cd9d7c
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update these two with new releases after the two PRs are merged

@github-actions
Copy link

Code Coverage

Package Line Rate Complexity Health
github.com/sei-protocol/sei-chain/aclmapping/bank 83% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/dex 100% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/oracle 100% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/staking 96% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/tokenfactory 96% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/utils 0% 0 ❌
github.com/sei-protocol/sei-chain/aclmapping/wasm 83% 0 ✔
github.com/sei-protocol/sei-chain/app 62% 0 ➖
github.com/sei-protocol/sei-chain/app/antedecorators 76% 0 ✔
github.com/sei-protocol/sei-chain/oracle/price-feeder/config 85% 0 ✔
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle 67% 0 ➖
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle/provider 49% 0 ❌
github.com/sei-protocol/sei-chain/oracle/price-feeder/router/v1 45% 0 ❌
github.com/sei-protocol/sei-chain/store/whitelist/cachemulti 100% 0 ✔
github.com/sei-protocol/sei-chain/store/whitelist/kv 100% 0 ✔
github.com/sei-protocol/sei-chain/store/whitelist/multi 100% 0 ✔
github.com/sei-protocol/sei-chain/utils 59% 0 ➖
github.com/sei-protocol/sei-chain/utils/datastructures 90% 0 ✔
github.com/sei-protocol/sei-chain/utils/logging 100% 0 ✔
github.com/sei-protocol/sei-chain/x/dex 58% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/cache 87% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/client/cli/query 22% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/contract 53% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/exchange 94% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/keeper 62% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/keeper/abci 24% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/keeper/msgserver 79% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/keeper/query 82% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/migrations 88% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/types 1% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/types/utils 100% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/types/wasm 50% 0 ➖
github.com/sei-protocol/sei-chain/x/epoch 11% 0 ❌
github.com/sei-protocol/sei-chain/x/epoch/keeper 66% 0 ➖
github.com/sei-protocol/sei-chain/x/epoch/types 2% 0 ❌
github.com/sei-protocol/sei-chain/x/mint 0% 0 ❌
github.com/sei-protocol/sei-chain/x/mint/keeper 61% 0 ➖
github.com/sei-protocol/sei-chain/x/mint/simulation 95% 0 ✔
github.com/sei-protocol/sei-chain/x/mint/types 3% 0 ❌
github.com/sei-protocol/sei-chain/x/nitro/client/cli 45% 0 ❌
github.com/sei-protocol/sei-chain/x/nitro/keeper 83% 0 ✔
github.com/sei-protocol/sei-chain/x/nitro/replay 63% 0 ➖
github.com/sei-protocol/sei-chain/x/oracle 67% 0 ➖
github.com/sei-protocol/sei-chain/x/oracle/keeper 83% 0 ✔
github.com/sei-protocol/sei-chain/x/oracle/simulation 18% 0 ❌
github.com/sei-protocol/sei-chain/x/oracle/types 3% 0 ❌
github.com/sei-protocol/sei-chain/x/tokenfactory/keeper 85% 0 ✔
github.com/sei-protocol/sei-chain/x/tokenfactory/types 2% 0 ❌
Summary 15% (5210 / 34285) 0 ❌

@LCyson LCyson merged commit 85371cd into master Mar 31, 2023
LCyson pushed a commit that referenced this pull request Mar 31, 2023
Update EventAttribute type (#658)
4969531 
IBC Compatibility change

Co-authored-by: Cyson <cyson@Cysons-MBP.attlocal.net>
LCyson pushed a commit that referenced this pull request Mar 31, 2023
Revert "Update EventAttribute type (#658)"
e4abb08 
This reverts commit 4969531.
LCyson pushed a commit that referenced this pull request Mar 31, 2023
Update EventAttribute type (#658)
2864551 
IBC Compatibility change

Co-authored-by: Cyson <cyson@Cysons-MBP.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipsu522 philipsu522 philipsu522 approved these changes

@BrandonWeng BrandonWeng BrandonWeng approved these changes

@udpatil udpatil Awaiting requested review from udpatil

@Kbhat1 Kbhat1 Awaiting requested review from Kbhat1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LCyson @philipsu522 @BrandonWeng