Revert EventAttribute field types #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
reviewed
Mar 15, 2023
| @@ -145,7 +145,7 @@ replace ( | |||
| github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.7.0 | |||
| github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
|
|
|||
| github.com/tendermint/tendermint => github.com/sei-protocol/sei-tendermint v0.1.171 | |||
| github.com/tendermint/tendermint => github.com/sei-protocol/sei-tendermint v0.1.179-0.20230315064114-c903df251edf | |||
There was a problem hiding this comment.
Can we tag a new tendermint release instead
There was a problem hiding this comment.
+1. Let's revert this and the protocol-team can cut a new release
There was a problem hiding this comment.
yes will update it to a tm release after this is merged sei-protocol/sei-tendermint#85
philipsu522
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR updates EventAttribute
keyandvaluedata type. Please find details in this PR sei-protocol/sei-tendermint#85Testing performed to validate your change