Revert EventAttribute types #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Change seems fine but similar comment here: sei-protocol/sei-cosmos#195 (review)
Could we test this out in a loadtest cluster before deploying to sei-devnet-3?
philipsu522
approved these changes
Mar 15, 2023
Timwood0x10
pushed a commit
to Timwood0x10/sei-tendermint
that referenced
this pull request
Jun 7, 2023
…tocol#85) ## Describe your changes and provide context This adds some resources that were previously missing from the resource tree. It also adds a unit test that requires ALL defined resource proto enum values to be keys in the resource tree. ## Testing performed to validate your change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR reverts the following RPC data type changes that affect both FE and IBC channel queries:
The intention to revert them is because we found that these changes conflict with most of existing cosmos auxiliary packages (including FE / IBC hermes / tendermint-rs and potentially more).
Testing performed to validate your change