abci: remove unused fields from CheckTXResponse (part 1) #8605
Conversation
jmalicevic
requested review from
ebuchman,
cmwaters,
tychoish,
williambanfield,
creachadair,
sergio-mena,
thanethomson and
ancazamfir
as code owners
|
can the title of this PR (and thus the commit once squashed) follow our convention (e.g. something like "abci: remove unused info/error fields" |
jmalicevic
changed the title
jmalicevic
changed the title
I will do it now, I'll try to check the docs n other places as well. There are a few places where Info, Log and Event are mentioned in relation to ResponseCheckTx. |
tychoish
changed the title
Thanks a lot, I appreciate it |
jmalicevic
requested review from
josef-widder,
milosevic and
cason
as code owners
| return &coretypes.ResultBroadcastTx{ | ||
| Code: c.Code, | ||
| Data: c.Data, | ||
| Log: c.Log, | ||
| Codespace: c.Codespace, | ||
| Hash: tx.Hash(), | ||
| }, nil |
There was a problem hiding this comment.
Do we actually remove Log from ResultBroadcastTx somewhere?
There was a problem hiding this comment.
I just removed it. Can you verify that this (ResultBroadcastTx) refers only to CheckTx result
light/provider/mocks/provider.go
Outdated
| type NewProviderT interface { | ||
| mock.TestingT | ||
| Cleanup(func()) | ||
| } | ||
|
|
||
| // NewProvider creates a new instance of Provider. It also registers a testing interface on the mock and a cleanup function to assert the mocks expectations. | ||
| func NewProvider(t NewProviderT) *Provider { |
There was a problem hiding this comment.
What's with the new mock types?
There was a problem hiding this comment.
That was because of the recent Dependabot update to Mockery. It should go away once the PR is rebased.
This PR removes the following fields from
ResponseCheckTx:InfoLogGasUsedEvents.A separate PR will futher remove
MempoolErroras this field is set by Tendermint and should be separated from the application response toCheckTx.