Fix getRawPacketReadOnly() const-correctness #1573 (#1637)

* Fix getRawPacketReadOnly() const-correctness #1573 * fix kni * fix clang-format * Add ignore list for clang-tidy * Revert "Add ignore list for clang-tidy" This reverts commit dc3783c.
seladb · Nov 8, 2024 · 2c50e2e · 2c50e2e
1 parent 426ad95
commit 2c50e2e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Packet++/header/Packet.h b/Packet++/header/Packet.h
@@ -178,7 +178,7 @@ namespace pcpp
 		 * Get a pointer to the Packet's RawPacket in a read-only manner
 		 * @return A pointer to the Packet's RawPacket
 		 */
-		RawPacket* getRawPacketReadOnly() const
+		const RawPacket* getRawPacketReadOnly() const
 		{
 			return m_RawPacket;
 		}

diff --git a/Pcap++/src/KniDevice.cpp b/Pcap++/src/KniDevice.cpp
@@ -610,11 +610,10 @@ namespace pcpp
 		MBufRawPacket** allocated = CPP_VLA(MBufRawPacket*, arrLength);
 		uint16_t allocated_count = 0, packetsSent = 0;
 		MBufRawPacket* rawPacket;
-		RawPacket* raw_pkt;
 
 		for (uint16_t i = 0; i < arrLength; ++i)
 		{
-			raw_pkt = packetsArr[i]->getRawPacketReadOnly();
+			const auto* raw_pkt = packetsArr[i]->getRawPacketReadOnly();
 			uint8_t raw_type = raw_pkt->getObjectType();
 			if (raw_type != MBUFRAWPACKET_OBJECT_TYPE)
 			{