Fix getRawPacketReadOnly() const-correctness #1573

[egecetin]

Fix #1573

Requires #1638

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (426ad95) to head (4ac3c0d).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1637      +/-   ##
==========================================
- Coverage   83.13%   83.13%   -0.01%     
==========================================
  Files         276      276              
  Lines       47318    47318              
  Branches     9537     9542       +5     
==========================================
- Hits        39338    39336       -2     
- Misses       7110     7111       +1     
- Partials      870      871       +1     

Flag	Coverage Δ
fedora40	75.22% <ø> (-0.01%)	⬇️
macos-13	80.67% <100.00%> (ø)
macos-14	80.67% <100.00%> (ø)
macos-15	80.64% <100.00%> (ø)
mingw32	70.79% <ø> (-0.05%)	⬇️
mingw64	70.76% <ø> (-0.05%)	⬇️
npcap	85.18% <ø> (-0.02%)	⬇️
rhel94	75.06% <ø> (-0.03%)	⬇️
ubuntu2004	58.68% <ø> (-0.01%)	⬇️
ubuntu2004-zstd	58.78% <ø> (-0.01%)	⬇️
ubuntu2204	74.98% <ø> (ø)
ubuntu2204-icpx	61.47% <100.00%> (ø)
ubuntu2404	75.27% <ø> (+0.02%)	⬆️
unittest	83.13% <100.00%> (-0.01%)	⬇️
windows-2019	85.22% <ø> (-0.02%)	⬇️
windows-2022	85.24% <ø> (-0.02%)	⬇️
winpcap	85.21% <ø> (ø)
xdp	50.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[seladb]

@egecetin can you fix clang-format?

[egecetin]

Hmm I wasn't expecting this while changing clang-tidy script. It can't find header because this container doesn't have kni (or same for dpdk etc). But since the file is changed it tries to analyze it.

[egecetin]

@seladb I'll split PR for clang-tidy script changes if it passes. Just pushed here for testing

[seladb]

@seladb I'll split PR for clang-tidy script changes if it passes. Just pushed here for testing

Why ignore those files altogether? Can't we just ignore those specific issues?

[egecetin]

@seladb There is no way to ignore clang-diagnostic-error unfortunately because it is a compile error. Old clang-tidy check was based on full compile, so these headers/source files are not checked since they are not enabled. But now it just trying to check if anything is changed

[seladb]

@seladb There is no way to ignore clang-diagnostic-error unfortunately because it is a compile error. Old clang-tidy check was based on full compile, so these headers/source files are not checked since they are not enabled. But now it just trying to check if anything is changed

yes, I just saw this stackoverflow response 😕 : https://stackoverflow.com/a/67487680