Remove TimeZone & etc. Fixes #650 #815
Conversation
Jamie-SA
added
the
impact: major
docs/release_notes/issue650.md
Outdated
| @@ -0,0 +1,10 @@ | |||
| ### Major Updates | |||
|
|
|||
| Addresses issue #650. | |||
There was a problem hiding this comment.
Could add the link here. #650
There was a problem hiding this comment.
I would like to see some descriptive text here, as we typically do with our release notes. For example:
- Renamed
gist:Task,gist:ScheduledTaskandgist:Projecttogist:TaskExecution,gist:ScheduledTaskExecutionandgist:ProjectExecution, respectively. Issue #590.
This includes the link and backticks that Dylan has suggested.
There was a problem hiding this comment.
@rjyounes I'm not sure what more information you would like to see. Your example shows saying those things were renamed. Below I've already said what things were removed. I think what I have is similar to your example.
docs/release_notes/issue650.md
Outdated
| Addresses issue #650. | ||
|
|
||
| Removes | ||
| - gist:TimeZone |
docs/release_notes/issue650.md
Outdated
| @@ -0,0 +1,10 @@ | |||
| ### Major Updates | |||
|
|
|||
| Addresses issue #650. | |||
There was a problem hiding this comment.
I would like to see some descriptive text here, as we typically do with our release notes. For example:
- Renamed
gist:Task,gist:ScheduledTaskandgist:Projecttogist:TaskExecution,gist:ScheduledTaskExecutionandgist:ProjectExecution, respectively. Issue #590.
This includes the link and backticks that Dylan has suggested.
gistCore.ttl
Outdated
| @@ -2854,7 +2820,7 @@ The subproperties allow the ontologist to do three things: | |||
|
|
|||
| All datetimes are of the same format: '2021-06-01T08:03:27.12324-6:00'^^xsd:dateTime. This is compatible with and a subset of ISO 8601. | |||
|
|
|||
| Time zone offset, such as -6:00 (of which there are a few dozen) is recognized in the date itself, as shown. The actual time zone standard (of which there are 131) may optionally be attached to the event or other object itself; see property gist:usesTimeZoneStandard. | |||
| Time zone offset, such as -6:00 (of which there are a few dozen) is recognized in the date itself, as shown. The actual time zone standard (of which there are 131) may optionally be attached to the event or other object itself. | |||
There was a problem hiding this comment.
I would like to get rid of the second sentence about time zone standard, since we couldn't agree yesterday about what a time zone standard is. Since we deleted the property the comment isn't very relevant anyway - I.e., we are not providing a way to attach the standard to the event.
There was a problem hiding this comment.
I think the second sentence is useful information, even if we don't provide a mechanism to do this. I do think the first sentence could be improved and I'll think about changes to the second sentence, but I don't see the need to remove the second sentence.
gistCore.ttl
Outdated
| @@ -2854,7 +2820,7 @@ The subproperties allow the ontologist to do three things: | |||
|
|
|||
| All datetimes are of the same format: '2021-06-01T08:03:27.12324-6:00'^^xsd:dateTime. This is compatible with and a subset of ISO 8601. | |||
|
|
|||
| Time zone offset, such as -6:00 (of which there are a few dozen) is recognized in the date itself, as shown. The actual time zone standard (of which there are 131) may optionally be attached to the event or other object itself; see property gist:usesTimeZoneStandard. | |||
| A time zone offset, such as -6:00, can be included as part of the datetime itself, as shown. The offset is not the same as a time zone. There are roughly a few dozen time zone offsets and around 130 named time zones. If needed, a time zone may be recorded by attaching it to the event or other object. | |||
There was a problem hiding this comment.
If needed, a time zone may be recorded by attaching it to the event or other object.
Since we are removing the classes, this should also be removed.
|
@dylan-sa Can you review Jamie's changes in response to your review comments, and approve it or submit a new request for changes? This is close to being ready to merge to develop. |
Fixes #650
Removes