-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TreatyOrganization (accidentally left in) #877
Remove TreatyOrganization (accidentally left in) #877
Conversation
@dylan-sa does this look right? |
Getting close to what we need, but looks like Heather's changes to the annotations for If you change the prefLabel, definition, and example for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to change the annotations for IntergovernmentalOrganization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes are complete
I did some more digging here and believe I found the root of the issue. It looks like one of my commits on the inverses branch was not caught up with some of the work that came right before it. (Surprising to me since I had made a point to merge the develop branch into my inverses branch, but it appears that not everything was updated as expected.) So, I've looked to see what exactly got lost, and I believe this is what we need to get caught up:
As best I can tell, this would fill in the gaps, but I would appreciate some more eyes on this just to make sure I've got it right. (@stevenchalem @rjyounes @Jamie-SA, if you could please take a look.) If this is looking right, I can make the remaining changes since my branch appears to be the culprit. |
I looked and I think all of the TimeZone changes, including the |
I retract my last statement... due to something I was working on, I was not looking at the correct version of gistCore.ttl. |
@dylan-sa I think you've caught everything. |
Thank you, @Jamie-SA. With the TimeInterval PR, I believe we're all caught up. 👍 |
Hopefully everything is fixed now... |
Peter found at the last minute that TreatyOrganization was still present in gistCore.ttl. This PR is to remove it consistent with the intention of issue #766 and pr #825