-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate StopLight.io's Prism mock server on Travis CI and locally #159
Comments
Hi @thinkingserious. |
@felipewmartins Awesome! Please be sure to fill out our CLA so we can merge you changes: https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#cla |
@felipewmartins hi! are u working on this issue? |
hi @dmitraver. No at this moment. |
@felipewmartins I can work on that if you are not planning to finish it. |
Hello Everyone, Is anyone on this thread still interested in submitting a PR? Thanks! |
Hi,
I can do this :)
…On 29 April 2017 at 07:28, Elmer Thomas ***@***.***> wrote:
Hello Everyone,
Is anyone on this thread still interested in submitting a PR?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABtwDGgGeCsk2v7URR6H29ba1jubbIebks5r0sqRgaJpZM4KVCoJ>
.
--
Best wishes,
Dmitry Avershin.
|
Awesome, thanks @dmitraver! |
FYI I'm gonna push a change for review soon. |
Hi @dmitraver, Just checking in. How is it going? |
hi @thinkingserious, Started working on that but haven't finished and then simply forgot about it, sorry. I will try to finish it this week though, thanks for pointing out |
Thanks @dmitraver! |
hi, I wasn't very active on a github since very long time, was really busy with some other stuff but want to be back on track. I already started last time and nearly get it to work with a local tests. I think I will finish it and make a PR asap. |
@thinkingserious my original idea was to add the logic of starting the prism in bash script which is executed before running test suite from gradle. I kind of prefer this approach versus having the logic of starting prism from Java. What do you think? I've also seen that the project has a pom.xml which means that if I do it this way I would probably need to add this logic to maven as well. |
Hi @dmitraver, So the idea is that at build time prism will be downloaded (if necessary) and run? If so, that sounds good to me. We also want to provide an easy way to shut down prism. At first I thought we should automatically shut it down after running the tests, but when you are actively developing, you probably want prism to be running for the duration of your development session. With Best Regards, Elmer |
Issue Summary
In the Travis CI and local environment:
References
https://stoplight.io/prism
https://raw.githubusercontent.com/sendgrid/sendgrid-oai/master/oai_stoplight.json
We have already done this in these libraries:
Python:
https://github.com/sendgrid/sendgrid-python/blob/master/.travis.yml#L14
https://github.com/sendgrid/sendgrid-python/blob/master/test/prism.sh
https://github.com/sendgrid/sendgrid-python/blob/master/test/test_sendgrid.py#L22
PHP:
https://github.com/sendgrid/sendgrid-php/blob/master/.travis.yml#L3
https://github.com/sendgrid/sendgrid-php/blob/master/test/prism.sh
https://github.com/sendgrid/sendgrid-php/blob/master/test/unit/SendGridTest.php#L13
C#:
https://github.com/sendgrid/sendgrid-csharp/blob/master/.travis.yml#L9
https://github.com/sendgrid/sendgrid-csharp/tree/master/prism
https://github.com/sendgrid/sendgrid-csharp/blob/master/SendGrid/UnitTest/UnitTest.cs#L23
Go:
https://github.com/sendgrid/sendgrid-go/blob/master/.travis.yml#L4
https://github.com/sendgrid/sendgrid-go/blob/master/prism.sh
https://github.com/sendgrid/sendgrid-go/blob/master/sendgrid_test.go#L35
The text was updated successfully, but these errors were encountered: