Adds an attachment builder that supports InputStream content. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing content as InputStream.
thinkingserious
added
type: community enhancement
|
Surprisingly the build has failed although I haven't changed any of the existing code except that adding an inner static class. I will check whats wrong with it. |
|
Hi @dmitraver, The tests will not work on Travis CI while this ticket is unresolved: #159 For now, please just make sure the tests pass locally with this procedure: https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#testing Sorry for the inconvenience :( |
|
Yeah, I run all the tests locally and everything was fine. |
|
Thanks again for your PR @dmitraver! Please take a moment to fill out this form so that we may send you some swag :) |
|
Awesome, good to hear that :) I would fill the form.
|
RichardCSantana-zz
pushed a commit
to RichardCSantana-zz/sendgrid-java
that referenced
this pull request
Apr 12, 2017
…ports InputStream content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134.
Adds an attachment builder class that helps creating content from InputStream as well as simple strings.