Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module option that enables/disables Magento stock newsletter emails #16

Merged
9 commits merged into from
Jan 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2021

Added new option to module settings that solves #15

"Magento welcome/goodbye emails"
"Send opt-in and opt-out emails via Magento store. Disable if you have already set up opt-in/opt-out workflows in Smaily dashboard!"

Extending subscriber model and overwriting its email functions to not send a newsletter related email if Smaily module is enabled & Magento welcome/goodbye emails are disabled.

Any suggestions on naming the option would be great, not sure what to call it. Disable Magento newsletter emails?

@ghost ghost marked this pull request as ready for review January 26, 2021 12:51
@ghost ghost requested a review from kaittodesk January 26, 2021 12:51
@ghost ghost added the enhancement New feature or request label Jan 26, 2021
@ghost ghost changed the title Feature/double confirmation emails Module option that enables/disables Magento stock newsletter emails Jan 26, 2021
Copy link
Member

@kaittodesk kaittodesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify the implementation.

I think it would be better if we tie disabling Magento welcome and goodbye emails with Smaily welcome emails feature Enable selection, i.e. when Smaily welcome emails are enabled then Magento welcome emails are disabled. This way we can push the user to use Smaily more, and it will make the plugin setup user guide easier to follow.

@ghost
Copy link
Author

ghost commented Jan 27, 2021

I think it would be better if we tie disabling Magento welcome and goodbye emails with Smaily welcome emails feature Enable selection, i.e. when Smaily welcome emails are enabled then Magento welcome emails are disabled. This way we can push the user to use Smaily more, and it will make the plugin setup user guide easier to follow.

I agree with your standpoint.

Initially, I made the option so users who do not want to set up automation workflows can still send hello emails, and for the purpose to be extra clear on how to fix the double welcome email issue people may experience.

Revising it and taking the related issue, for example, users are under the assumption Magento will not send any hello emails itself if Smaily opt-in option is enabled. Ditching the option would make the module more intuitive for end-users.

@ghost ghost requested a review from kaittodesk January 28, 2021 10:45
@ghost ghost merged commit 6ff29c0 into release/2.2.0 Jan 28, 2021
@ghost ghost deleted the feature/double-confirmation-emails branch January 28, 2021 11:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants