-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module option that enables/disables Magento stock newsletter emails #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's simplify the implementation.
I think it would be better if we tie disabling Magento welcome and goodbye emails with Smaily welcome emails feature Enable selection, i.e. when Smaily welcome emails are enabled then Magento welcome emails are disabled. This way we can push the user to use Smaily more, and it will make the plugin setup user guide easier to follow.
I agree with your standpoint. Initially, I made the option so users who do not want to set up automation workflows can still send hello emails, and for the purpose to be extra clear on how to fix the double welcome email issue people may experience. Revising it and taking the related issue, for example, users are under the assumption Magento will not send any hello emails itself if Smaily opt-in option is enabled. Ditching the option would make the module more intuitive for end-users. |
Added new option to module settings that solves #15
Extending subscriber model and overwriting its email functions to not send a newsletter related email if Smaily module is enabled & Magento welcome/goodbye emails are disabled.
Any suggestions on naming the option would be great, not sure what to call it. Disable Magento newsletter emails?