Skip to content

Commit

Permalink
Fixed EIO_List to prevent crash when a device has no COM port (#2325)
Browse files Browse the repository at this point in the history
  • Loading branch information
caffeinatedbits authored Sep 29, 2021
1 parent 494fd0f commit 3ca00ce
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/bindings/src/serialport_win.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,7 @@ void EIO_List(uv_work_t* req) {
char serialNumber[MAX_REGISTRY_KEY_SIZE];
bool isCom;
while (true) {
isCom = false;
pnpId = NULL;
vendorId = NULL;
productId = NULL;
Expand Down

2 comments on commit 3ca00ce

@gabrieleimotion
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I am experiencing the exact problem with a Brother printer when the app is crashing on taking the COM list.
How can I compile the latest version of the library on windows?

@reconbot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in @serialport/bindings@9.2.4

Please sign in to comment.