fix(editor): Modal in moodle #4360
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
104.87 KB (🟡 +8 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/___editor_preview |
637.23 KB (🟡 +1 B) |
742.1 KB |
/entity/create/[type]/[taxonomyId] |
657.5 KB (🟡 +1 B) |
762.38 KB |
/entity/repository/add-revision/[...id] |
657.24 KB (🟡 +1 B) |
762.11 KB |
/page/create |
657.22 KB (🟡 +1 B) |
762.1 KB |
/taxonomy/term/create/[parent_id]/[id] |
656.97 KB (🟡 +1 B) |
761.84 KB |
/taxonomy/term/update/[id] |
656.92 KB (🟡 +1 B) |
761.79 KB |
/user/settings |
658.89 KB (🟡 +1 B) |
763.76 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
There was a problem hiding this comment.
"in the z-index wars there are no winners"
(I checked: The modal should be the highest z-index element currently so even though I also don't like this it should be ok)
Related:
Will we not be iframed in moodle as well? (that would make this change unnecessary, right?)
We won't for now, only in Chancenwerk. In Moodle they were able to turn off the outside Shadow DOM. I think style collisions and issues will be an ongoing fight! |
and is that better than the alternatives in your opinion? |
I don't love it, but for the modal to not collide with the navigation bar of Moodle, we'd need a z-index higher than 1030 😬