Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Modal on serlo.org by applying high z-index only in integrations on content instead of overlay #4373

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

CodingDive
Copy link
Contributor

Reverts and fixes the problem I introduced in #4360

…serlo.org and on the content directly instead of the overlay
@CodingDive CodingDive requested a review from elbotho December 22, 2024 22:37
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 23, 2024 1:16am

Copy link
Contributor

github-actions bot commented Dec 22, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.88 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 663.61 KB (🟡 +18 B) 768.48 KB
/entity/create/[type]/[taxonomyId] 683.89 KB (🟡 +18 B) 788.77 KB
/entity/repository/add-revision/[...id] 683.62 KB (🟡 +18 B) 788.5 KB
/page/create 683.61 KB (🟡 +18 B) 788.49 KB
/taxonomy/term/create/[parent_id]/[id] 683.36 KB (🟡 +18 B) 788.23 KB
/taxonomy/term/update/[id] 683.3 KB (🟡 +18 B) 788.18 KB
/user/settings 685.27 KB (🟡 +18 B) 790.15 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho merged commit 2118011 into staging Dec 23, 2024
9 checks passed
@elbotho elbotho deleted the fix/editor-modal-on-serlo branch December 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants