Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case-sensitivity #192

Closed
dcastro opened this issue Oct 12, 2022 · 0 comments · Fixed by #194
Closed

Test case-sensitivity #192

dcastro opened this issue Oct 12, 2022 · 0 comments · Fixed by #194
Assignees
@Sorokin-Anton
Milestone
0.2.2

Comments

@dcastro
Copy link
Member

dcastro commented Oct 12, 2022 •
edited
Loading

Clarification and motivation

One more quirk I just came across while reading the docs of equalFilePath:

On linux, filepaths are case-sensitive. So, if you have a file named a and a link to A, the link is invalid.
Both GitHub and GitLab's URIs are also case-sensitive:

So we should have tests for case-sensitivity.

Windows paths, however, are case-insensitive. So these tests will also be useful for #164

Acceptance criteria

  • We have tests for case-sensitivity.
@dcastro dcastro added this to the 0.2.2 milestone Oct 12, 2022
Sorokin-Anton added a commit that referenced this issue Oct 13, 2022
@Sorokin-Anton
[#165] [#192] Add tests for specific cases
3e6908d 
Problem: there is no tests for links to directories and non-markdown files.
Also we aren't testing that links are case sensetive

Solution: add such tests to `check-local-refs`, also check that only links
to directory are allowed to have trailing slash,
e.g. `a.md/` is bad and `dir1/` is ok
@Sorokin-Anton Sorokin-Anton mentioned this issue Oct 13, 2022
Merged
8 tasks
Sorokin-Anton added a commit that referenced this issue Oct 13, 2022
@Sorokin-Anton
[#165] [#192] Add tests for specific cases
f90b915 
Problem: there is no tests for links to directories and non-markdown files.
Also we aren't testing that links are case sensetive

Solution: add such tests to `check-local-refs`, also check that only links
to directory are allowed to have trailing slash,
e.g. `a.md/` is bad and `dir1/` is ok
Sorokin-Anton added a commit that referenced this issue Oct 13, 2022
@Sorokin-Anton
[#165] [#192] Add tests for specific cases
22b3ce1 
Problem: there is no tests for links to directories and non-markdown files.
Also we aren't testing that links are case sensetive

Solution: add such tests to `check-local-refs`, also check that only links
to directory are allowed to have trailing slash,
e.g. `a.md/` is bad and `dir1/` is ok
Sorokin-Anton added a commit that referenced this issue Oct 14, 2022
@Sorokin-Anton
fixup! [#165] [#192] Add tests for specific cases
a03c9ff
Sorokin-Anton added a commit that referenced this issue Oct 18, 2022
@Sorokin-Anton
Merge pull request #194 from serokell/Sorokin-Anton/#165-test-differe…
c2aad89 
…nt-local-refs

[#165] [#192] Add tests for specific cases of local references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sorokin-Anton Sorokin-Anton

Labels
None yet
Projects
None yet
Milestone
0.2.2
Development

Successfully merging a pull request may close this issue.

[#165] [#192] Add tests for specific cases of local references serokell/xrefcheck
2 participants
@dcastro @Sorokin-Anton