[#165] [#192] Add tests for specific cases of local references #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorokin-Anton
force-pushed
the
Sorokin-Anton/#165-test-different-local-refs
branch
from
3e6908d to
f90b915
Compare
Problem: there is no tests for links to directories and non-markdown files. Also we aren't testing that links are case sensetive Solution: add such tests to `check-local-refs`, also check that only links to directory are allowed to have trailing slash, e.g. `a.md/` is bad and `dir1/` is ok
Sorokin-Anton
force-pushed
the
Sorokin-Anton/#165-test-different-local-refs
branch
from
f90b915 to
22b3ce1
Compare
dcastro
reviewed
Oct 14, 2022
|
|
||
| [existing-anchor-rel-1](d2f2.md#existing-anchor-d2f2) | ||
| [existing-anchor-rel-2](./d2f2.md#existing-anchor-d2f2) | ||
| [existing-anchor-rel-3](../dir2/../d1f1.md#existing-anchor-d1f1) | ||
|
|
||
| [bad-file-rel](../a/b/c/unexisting-file.md) | ||
| [bad-slash-file-rel](d2f2.md/) |
There was a problem hiding this comment.
This link should be valid, both github and gitlab correctly link to [a](./README.md/). I'll create an issue for this.
There was a problem hiding this comment.
Ok, I left this untouched (with a comment referencing issue)
12 tasks
dcastro
approved these changes
Oct 18, 2022
Sorokin-Anton
changed the title
Sorokin-Anton
deleted the
Sorokin-Anton/#165-test-different-local-refs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: there is no tests for links to directories and non-markdown files. Also we aren't testing that links are case sensetive
Solution: add such tests to
check-local-refs, also check that only links to directory are allowed to have trailing slash,e.g.
a.md/is bad anddir1/is okRelated issue(s)
Fixes #165
Fixes #192
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)