Revise behaviour of dump-config command
#254
Assignees
Milestone
Comments
aeqz
added a commit
that referenced
this issue
Dec 22, 2022
Problem: xrefcheck does not allow to print the config to stdout instead of writing it to a file. Also, it is easy to overwrite you changes by mistake by executing the command again. Solution: provide a --stdout flag to print the config to stdout, and do not write it to a file unless a --force flag has been included.
aeqz
added a commit
that referenced
this issue
Dec 22, 2022
aeqz
added a commit
that referenced
this issue
Dec 22, 2022
Problem: xrefcheck does not allow to print the config to stdout instead of writing it to a file. Also, it is easy to overwrite your changes by mistake by executing the command again. Solution: provide a --stdout flag to print the config to stdout, and do not write it to a file unless a --force flag has been included.
aeqz
added a commit
that referenced
this issue
Dec 22, 2022
aeqz
added a commit
that referenced
this issue
Dec 23, 2022
Problem: xrefcheck does not allow to print the config to stdout instead of writing it to a file. Also, it is easy to overwrite your changes by mistake by executing the command again. Solution: provide a --stdout flag to print the config to stdout, and do not write it to a file unless a --force flag has been included.
aeqz
added a commit
that referenced
this issue
Dec 29, 2022
…mmand [#254] Revise dump-config command
PhilTaken
pushed a commit
that referenced
this issue
Jan 18, 2023
Problem: xrefcheck does not allow to print the config to stdout instead of writing it to a file. Also, it is easy to overwrite your changes by mistake by executing the command again. Solution: provide a --stdout flag to print the config to stdout, and do not write it to a file unless a --force flag has been included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clarification and motivation
Currently this command immediately writes to a file, while an intuition would say that it should just print config to the console. (and actually, it was me who implemented it this way 😓). But okay, this has some advantages.
But this command can also overwrite the previously created config. I.e. I could create config and tune it up, then accidentally call
xrefcheck dump-configagain (e.g. by getting this command from history) and all my changes will be lost. This is too bad.Acceptance criteria
dump-configdoes not overwrite the existing file, unless this is told explicitly (with some--forceflag).The text was updated successfully, but these errors were encountered: