[#254] Revise dump-config command #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martoon-00
reviewed
Dec 22, 2022
Martoon-00
reviewed
Dec 22, 2022
aeqz
force-pushed
the
aeqz/#254-revise-dump-config-command
branch
from
353491c to
510eedf
Compare
Martoon-00
requested changes
Dec 22, 2022
| @@ -130,6 +130,7 @@ executables: | |||
| dependencies: | |||
| - xrefcheck | |||
| - universum | |||
| - directory | |||
There was a problem hiding this comment.
Mm, I wanted to ask you to follow the alphabetical order here, but it's really hard to follow 😒
There was a problem hiding this comment.
Don't worry. I will sort dependencies and default-extensions in a separate commit.
Martoon-00
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Awesome, thank you.
There is a typo in the 8edffa2 commit's subject, but other than that looks good.
Problem: xrefcheck does not allow to print the config to stdout instead of writing it to a file. Also, it is easy to overwrite your changes by mistake by executing the command again. Solution: provide a --stdout flag to print the config to stdout, and do not write it to a file unless a --force flag has been included.
Problem: some arrays from the package.yaml file seemed to be almost alphabetically sorted, but not completely. Solution: sort the default-extensions and dependencies arrays from the package.yaml file.
aeqz
force-pushed
the
aeqz/#254-revise-dump-config-command
branch
from
8edffa2 to
1c44c1c
Compare
aeqz
force-pushed
the
aeqz/#254-revise-dump-config-command
branch
from
15264ee to
c9486e7
Compare
|
This PR is quite small, I think let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: xrefcheck does not allow to print the config to stdout instead of writing it to a file. Also, it is easy to overwrite your changes by mistake by executing the command again.
Solution: provide a
--stdoutflag to print the config to stdout, and do not write it to a file unless a--forceflag has been included.Related issue(s)
Fixes #254
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)