Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle relative redirects #270

Closed
aeqz opened this issue Jan 25, 2023 · 0 comments · Fixed by #271
Closed

Handle relative redirects #270

aeqz opened this issue Jan 25, 2023 · 0 comments · Fixed by #271
Assignees
@aeqz
Milestone
0.3.0

Comments

@aeqz
Copy link
Contributor

aeqz commented Jan 25, 2023 •
edited
Loading

Clarification and motivation

When following redirects, we are not handling relative location paths, which can be either relative to the base URL or to the parent path of the original request: https://en.wikipedia.org/wiki/HTTP_location

Acceptance criteria

  • When following redirects, Xrefcheck differentiates and properly handles relative URL location paths.
  • Consider to show them with the absolute link in any redirect chain related error.
@aeqz aeqz added this to the 0.3.0 milestone Jan 25, 2023
@aeqz aeqz self-assigned this Jan 26, 2023
aeqz added a commit that referenced this issue Jan 26, 2023
@aeqz
[#270] Handle relative redirects
1e65514 
Problem: Currently, Xrefcheck can follow redirects with an absolute
location link, but it cannot handle relative ones.

Solution: After parsing the location link, obtain the corresponding
absolute link by using the original request one.
@aeqz aeqz mentioned this issue Jan 26, 2023
Merged
8 tasks
aeqz added a commit that referenced this issue Jan 26, 2023
@aeqz
fixup! [#270] Handle relative redirects
d2c778b
aeqz added a commit that referenced this issue Jan 26, 2023
@aeqz
[#270] Handle relative redirects
ac02933 
Problem: Currently, Xrefcheck can follow redirects with an absolute
location link, but it cannot handle relative ones.

Solution: After parsing the location link, obtain the corresponding
absolute link by using the original request one.
aeqz added a commit that referenced this issue Jan 27, 2023
@aeqz
[#270] Handle relative redirects
9c2ac77 
Problem: Currently, Xrefcheck can follow redirects with an absolute
location link, but it cannot handle relative ones.

Solution: After parsing the location link, obtain the corresponding
absolute link by using the original request one.
@aeqz aeqz closed this as completed in #271 Jan 27, 2023
aeqz added a commit that referenced this issue Jan 27, 2023
@aeqz
Merge pull request #271 from serokell/aeqz/#270-handle-relative-redir…
4a33023 
…ects

[#270] Handle relative redirects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeqz aeqz

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

[#270] Handle relative redirects serokell/xrefcheck
1 participant
@aeqz