[#270] Handle relative redirects #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeqz
commented
Jan 26, 2023
src/Xrefcheck/Verify.hs
Outdated
| Just nextLink -> do | ||
| nextUri <- ExternalResourceUriParseError `withExceptT` parseUri True nextLink | ||
| nextLinkAbsolute <- case relativeTo nextUri uri of | ||
| Nothing -> error "Not absolute URL exception" |
There was a problem hiding this comment.
This should not happen because uri has been parsed with parseUri False.
There was a problem hiding this comment.
I would put this explanation as code comment, it seems worthy.
aeqz
commented
Jan 26, 2023
| Nothing -> throwError $ RedirectMissingLocation $ followed `pushRequest` RedirectChainLink link | ||
| Just nextLink -> do | ||
| nextUri <- ExternalResourceUriParseError `withExceptT` parseUri True nextLink | ||
| nextLinkAbsolute <- case relativeTo nextUri uri of |
There was a problem hiding this comment.
I mainly used the relativeTo function from the modern-uri package for this task. This is how we obtain the absolute target link from the (absolute) source + the (absolute or relative) target.
aeqz
commented
Jan 26, 2023
| -- configurations of this type is 'strictURIParserOptions', which follows | ||
| -- RFC 3986, and the other -- 'laxURIParseOptions' -- allows brackets | ||
| -- in the queries, which draws us closer to the WHATWG URL standard. | ||
| uri <- case URIBS.parseURI URIBS.laxURIParserOptions (encodeUtf8 link) of |
There was a problem hiding this comment.
The modern-uri package can parse an URI deciding if it is absolute or relative depending on the success or failure of the scheme parsing. In uri-bytestring, it has to be decided beforehand, resulting in different URI types.
Martoon-00
reviewed
Jan 26, 2023
Martoon-00
approved these changes
Jan 26, 2023
aeqz
force-pushed
the
aeqz/#270-handle-relative-redirects
branch
from
d2c778b to
ac02933
Compare
Problem: Currently, Xrefcheck can follow redirects with an absolute location link, but it cannot handle relative ones. Solution: After parsing the location link, obtain the corresponding absolute link by using the original request one.
aeqz
force-pushed
the
aeqz/#270-handle-relative-redirects
branch
from
ac02933 to
9c2ac77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Currently, Xrefcheck can follow redirects with an absolute location link, but it cannot handle relative ones.
Solution: After parsing the location link, obtain the corresponding absolute link by using the original request one.
Related issue(s)
Fixes #270
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)