Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X509_PURPOSE #1788

Merged
merged 4 commits into from
Jan 16, 2023
Merged

X509_PURPOSE #1788

merged 4 commits into from
Jan 16, 2023

Conversation

bkstein
Copy link
Contributor

@bkstein bkstein commented Jan 13, 2023

  • X509_PURPOSE id's were implemented as bitfields, but they are just constants.
  • Renamed X509PurposeFlags to X509PurposeId, as this seems to be the naming used in OpenSSL.
  • Moved the definitions from x509/verify.rs to x509/mod.rs, as X509_PURPOSE is not specific to verification (X509_STORE also uses this).
  • This PR is also part 1/4 of the split PR Added pkcs7 support (this PR was split, do not merge) #1598, which grew too big over time.

@bkstein bkstein changed the title Kletterstein/x509purpose X509_PURPOSE Jan 13, 2023
This was referenced Jan 13, 2023
Closed
Open
Open
Draft
sfackler
sfackler reviewed Jan 14, 2023
View reviewed changes
openssl-sys/src/x509v3.rs Outdated Show resolved Hide resolved
sfackler
sfackler reviewed Jan 14, 2023
View reviewed changes
openssl/src/x509/mod.rs Outdated Show resolved Hide resolved
sfackler
sfackler reviewed Jan 14, 2023
View reviewed changes
openssl/src/x509/mod.rs Outdated Show resolved Hide resolved
sfackler
sfackler reviewed Jan 14, 2023
View reviewed changes
openssl/src/x509/store.rs Outdated Show resolved Hide resolved
@sfackler sfackler merged commit f0ef5f3 into sfackler:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkstein @sfackler