Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCS7 creation and reading #1791

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

bkstein
Copy link
Contributor

@bkstein bkstein commented Jan 13, 2023

@bkstein
Copy link
Contributor Author

bkstein commented Feb 28, 2023

@sfackler @Skepfyr After upgrading to the current master, I observe timeouts in the tests for openssl 3.1.0-beta1. See last action of this PR. I see this also on my Linux machine with another test (ssl::test::default_verify_paths). Is this a known issue with openssl 3.1.0-beta1?

@Skepfyr
Copy link
Collaborator

Skepfyr commented Mar 10, 2023

I'm not sure, this issue doesn't seem to be reproducing on the latest master pipelines and I'm not able to reproduce it locally at all. What was the environment of the machine you were seeing it on?

@bkstein
Copy link
Contributor Author

bkstein commented Mar 13, 2023

Hmm, I cloned the repo on a Kubuntu 22.04. I compiled openssl 3.1.0-beta1 and set the following environment:

LD_LIBRARY_PATH=/home/bkstein/.local/openssl/3.1.0-beta1/lib64
OPENSSL_DIR=/home/bkstein/.local/openssl/3.1.0-beta1
OPENSSL_LIBS=crypto:ssl
OPENSSL_STATIC=0

Then (--show-output to verify correct openssl version is used)

$ cargo build --all
$ cargo test -- --show-output

I see

     Running unittests src/lib.rs (target/debug/deps/openssl-7cf3b6cc4c3411cb)

running 341 tests
...
test pkcs7::tests::signed_pkcs7 ... ok
...
test ssl::test::default_verify_paths has been running for over 60 seconds
test ssl::test::default_verify_paths ... ok
...
---- version::test_versions stdout ----
Number: '806354944'
Version: 'OpenSSL 3.1.0-beta1 21 Dec 2022'
C flags: 'compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_BUILDING_OPENSSL -DNDEBUG'
Built on: 'built on: Tue Feb 28 14:30:08 2023 UTC'
Platform: 'platform: linux-x86_64'
Dir: 'OPENSSLDIR: "/home/bkstein/.local/openssl/3.1.0-beta1/ssl"'
...

test result: ok. 336 passed; 0 failed; 5 ignored; 0 measured; 0 filtered out; finished in 133.97s

This is reproducible on my machine. BTW, I see this problem with the system openssl 3.0.2, too.

@m-bachelier
Copy link

Hi ! I'm interested by this PR, I'd like to know when this request will be merged or at least when it will be rebased on the latest version so I can patch my project locally. :)

@bkstein
Copy link
Contributor Author

bkstein commented May 29, 2023

Hi ! I'm interested by this PR, I'd like to know when this request will be merged or at least when it will be rebased on the latest version so I can patch my project locally. :)

Hi @m-bachelier, I stopped keeping this PR up-to-date a while ago, as the review process stalled. Not sure what we can do to revive the process. I'd be happy to rebase, but not without some perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants