Preparing openssl-sys for PKCS7 and X509 extensions #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkstein
changed the title
This was referenced Jan 13, 2023
bkstein
force-pushed
the
kletterstein/openssl-sys
branch
from
2040594 to
d2e3018
Compare
Skepfyr
requested changes
Feb 12, 2023
|
Updated to current master: This branch has no conflicts with the base branch |
Skepfyr
approved these changes
Apr 10, 2023
Thank's for the reply and the merge. And I prefer a thorough review over a quick merge :). Feel free to ping me, if can help with updating my branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openssl_sys::openssl::handwritten::asn1::ASN1_TYPE, which was anenum, but should actually be astruct. This breaks compatibility. If this is not desired, we need to find another solution, but that would by dirty in my opinion (trying to appeal to the maintainer's honour).