fix: add type check to client ci, rm type errors

- remove base class from tutorial API that didn't get fully implemented
- remove TSX shim since this appears unused and causes compiler to
  complain

ref virtualcommons#878

.github/workflows/check-code.yml

@@ -2,48 +2,47 @@ name: Check Code Style/Lint
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
-
   client:
     runs-on: ubuntu-latest
     defaults:
       run:
         working-directory: ./client
     steps:
-    - uses: actions/checkout@v3
-    - name: Set up node
-      uses: actions/setup-node@v3
-      with:
-        node-version: 16
-    - name: Clean install
-      run: yarn install --frozen-lockfile
-    - name: Lint
-      run: yarn lint
-    - name: Check formatting
-      # run regardless of whether linting caught errors
-      if: ${{ success() || failure() }}
-      run: yarn style
+      - uses: actions/checkout@v3
+      - name: Set up node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16
+      - name: Clean install
+        run: yarn install --frozen-lockfile
+      - name: Lint
+        run: yarn lint
+      - name: Check formatting
+        # run regardless of whether linting caught errors
+        if: ${{ success() || failure() }}
+        run: yarn style
 
   server:
     runs-on: ubuntu-latest
     defaults:
       run:
         working-directory: ./server
     steps:
-    - uses: actions/checkout@v3
-    - name: Set up node
-      uses: actions/setup-node@v3
-      with:
-        node-version: 16
-    - name: Clean install
-      run: yarn install --frozen-lockfile
-    - name: Lint
-      run: yarn lint
-    - name: Check formatting
-      # run regardless of whether linting caught errors
-      if: ${{ success() || failure() }}
-      run: yarn style
+      - uses: actions/checkout@v3
+      - name: Set up node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16
+      - name: Clean install
+        run: yarn install --frozen-lockfile
+      - name: Lint
+        run: yarn lint
+      - name: Check formatting
+        # run regardless of whether linting caught errors
+        if: ${{ success() || failure() }}
+        run: yarn style

Makefile

@@ -128,7 +128,7 @@ deploy: build
 
 .PHONY: buildprod
 buildprod: docker-compose.yml
-	docker compose run --rm client yarn build
+	docker compose run --rm client yarn type-check-build
 	docker compose run --rm server yarn build
 
 .PHONY: clean

client/package.json

@@ -5,13 +5,15 @@
   "scripts": {
     "serve": "vue-cli-service serve",
     "build": "vue-cli-service build",
+    "type-check-build": "tsc --noEmit && vue-cli-service build",
     "loadtest": "ts-node -r tsconfig-paths/register src/loadtest.ts",
     "test:unit": "NODE_ENV=test vue-cli-service test:unit",
     "test:e2e": "vue-cli-service test:e2e",
     "lint": "eslint ./ --ext .ts,.vue",
     "lint:fix": "eslint --fix ./ --ext .ts,.vue",
     "style": "prettier --config ../.prettierrc --check 'src/**/*.{ts,vue}'",
-    "style:fix": "prettier --config ../.prettierrc --write 'src/**/*.{ts,vue}'"
+    "style:fix": "prettier --config ../.prettierrc --write 'src/**/*.{ts,vue}'",
+    "type-check": "tsc --noEmit"
   },
   "dependencies": {
     "@colyseus/schema": "^1.0.9",

client/src/api/tutorial/request.ts

@@ -14,10 +14,9 @@ import { ChatMarsLogView, HUDLeftView, HUDRightView } from "@port-of-mars/shared
 import * as _ from "lodash";
 import { Store } from "vuex/types/index";
 import { StateTransform } from "@port-of-mars/client/types/tutorial";
-import { AbstractGameAPI } from "@port-of-mars/client/api/game/types";
 import { SfxManager } from "@port-of-mars/client/util";
 
-export class TutorialAPI implements AbstractGameAPI {
+export class TutorialAPI {
   count: number = 1;
   private store!: Store<State>;
   private stateStack: Array<StateTransform[]> = [];