Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn build appears to fail on client (prod/staging) #878

Closed
alee opened this issue Aug 1, 2023 · 2 comments
Closed

yarn build appears to fail on client (prod/staging) #878

alee opened this issue Aug 1, 2023 · 2 comments

Comments

@alee
Copy link
Member

alee commented Aug 1, 2023

 => ERROR [server pom-client-builder-base 9/9] RUN yarn build                                                                                                                                                                    38.1s 
------                                                                                                             
 > [server pom-client-builder-base 9/9] RUN yarn build:                                                            
8.594 yarn run v1.22.19                                  
8.633 $ vue-cli-service build                   
9.206                         
9.207 -  Building for production...                                                                                
36.04  ERROR  Failed to compile with 1 error5:41:46 AM                                                             
36.04                                          
36.04  error  in src/api/tutorial/request.ts:20:14
36.04                                 
36.04 TS2420: Class 'TutorialAPI' incorrectly implements interface 'AbstractGameAPI'.                              
36.04   Type 'TutorialAPI' is missing the following properties from type 'AbstractGameAPI': stageDiscardOfPurchasedAccomplishment, savePersonalGainVote, voteForPhilanthropist, saveBondingThroughAdversitySelection, saveBreakdownOfTr
ust                                                                                                                
36.04     18 | import { SfxManager } from "@port-of-mars/client/util";                                             
36.04     19 |                      
36.04   > 20 | export class TutorialAPI implements AbstractGameAPI {
36.04        |              ^^^^^^^^^^^
36.04     21 |   count: number = 1;
36.04     22 |   private store!: Store<State>;
36.04     23 |   private stateStack: Array<StateTransform[]> = [];
36.04 
36.04  ERROR  Build failed with errors.
36.11 error Command failed with exit code 1.
36.11 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@alee alee changed the title build failing? yarn build appears to fail on client (prod/staging) Aug 1, 2023
@alee
Copy link
Member Author

alee commented Aug 1, 2023

hmm, couldn't reproduce it locally and then running make deploy on staging / prod worked. probably should look into it, I don't think we use TutorialAPI anymore at this point...

@alee alee closed this as completed Aug 1, 2023
@sgfost
Copy link
Contributor

sgfost commented Aug 1, 2023

Well the type checking error looks correct, curious why its only now complaining about it. All of the tutorial stuff is unused but it felt like it had too much potential value for me to ever rip it out, may be worth freezing it in a branch like how the nuxt app is now.

I'll remove that base class for now just so we don't run into it again

sgfost added a commit to sgfost/port-of-mars that referenced this issue Aug 1, 2023
- remove base class from tutorial API that didn't get fully implemented
- remove TSX shim since this appears unused and causes compiler to
  complain

ref virtualcommons#878
sgfost added a commit to sgfost/port-of-mars that referenced this issue Aug 1, 2023
- remove base class from tutorial API that didn't get fully implemented
- remove TSX shim since this appears unused and causes compiler to
  complain

ref virtualcommons#878
sgfost added a commit that referenced this issue Aug 1, 2023
- remove base class from tutorial API that didn't get fully implemented
- remove TSX shim since this appears unused and causes compiler to
  complain

ref #878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants