fix: add type check to client ci, remove type errors #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove base class from tutorial API that didn't get fully implemented - remove TSX shim since this appears unused and causes compiler to complain ref virtualcommons#878
alee
approved these changes
Aug 1, 2023
alee
reviewed
Aug 1, 2023
| @@ -128,7 +128,7 @@ deploy: build | |||
|
|
|||
| .PHONY: buildprod | |||
| buildprod: docker-compose.yml | |||
| docker compose run --rm client yarn build | |||
| docker compose run --rm client yarn type-check-build | |||
| docker compose run --rm server yarn build | |||
There was a problem hiding this comment.
is there a reason to not add type checking to the client's default yarn build (i.e., replace it instead of adding another command)
There was a problem hiding this comment.
Not really, no. I did it this way so it doesn't actually run on a real deploy but that doesn't make a ton of sense since we'd want to fix anything before deploying. I'll switch them around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #878