Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Support both xgrammar and outlines for constrained decoding #1752

Merged
merged 19 commits into from
Oct 25, 2024
Merged

[Performance] Support both xgrammar and outlines for constrained decoding #1752

merged 19 commits into from
Oct 25, 2024

Conversation

DarkSharpness
Copy link
Contributor

Motivation

This pull request is a continuation of PR #1680.

This pull request allows users to choose between xgrammar and outlines.

Modifications

Key modifications include:

  • Added support for both xgrammar and outlines as grammar backends.
  • Users can select their preferred backend by passing the grammar-backend option in the command line.
  • The default backend is set to outlines.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@merrymercy merrymercy mentioned this pull request Oct 23, 2024
Closed
3 tasks
merrymercy
merrymercy requested changes Oct 23, 2024
View reviewed changes
python/sglang/srt/managers/schedule_batch.py Outdated Show resolved Hide resolved
python/sglang/srt/managers/schedule_batch.py Outdated Show resolved Hide resolved
python/sglang/srt/managers/schedule_batch.py Outdated Show resolved Hide resolved
python/sglang/srt/managers/scheduler.py Outdated Show resolved Hide resolved
@merrymercy merrymercy mentioned this pull request Oct 23, 2024
Open
33 tasks
@merrymercy merrymercy enabled auto-merge (squash) October 25, 2024 21:30
@merrymercy merrymercy merged commit b77a02c into sgl-project:main Oct 25, 2024
12 checks passed
qeternity pushed a commit to qeternity/sglang that referenced this pull request Oct 27, 2024
@DarkSharpness @qeternity
[Performance] Support both xgrammar and outlines for constrained deco…
080e618 
…ding (sgl-project#1752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy approved these changes

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkSharpness @merrymercy