Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect highlighting of full word search results #170

Closed
bhajneet opened this issue Jun 24, 2019 · 2 comments · Fixed by #536
Closed

Fix incorrect highlighting of full word search results #170

bhajneet opened this issue Jun 24, 2019 · 2 comments · Fixed by #536
Assignees
@Jujhaar
Labels
Effort 1 Simple task (code/non-code). Impacts Some Affects the average end-user. ○ Type Bug Regressions/production issues that do not function as intended.
Milestone
[V2] Alpha 1

Comments

@bhajneet
Copy link
Member

Incorrect highlighting. See first letter in results 3-5.

image

Originally posted by @bhajneet in #161 (comment)
@Harjot1Singh Harjot1Singh added the ○ Type Bug Regressions/production issues that do not function as intended. label Jun 25, 2019
@Harjot1Singh Harjot1Singh changed the title Fix incorrect highlighting of search results Fix incorrect highlighting of full word search results Jun 25, 2019
@Harjot1Singh Harjot1Singh added Impacts Some Affects the average end-user. Status: Confirmed labels Jun 25, 2019
@Harjot1Singh Harjot1Singh added this to the [V2] Alpha 1 milestone Jun 30, 2019
@bhajneet
Copy link
Member Author

The entire word should be highlighted even if it's a partial match of the beginning.

Child of #211

@bhajneet bhajneet mentioned this issue Oct 13, 2019
Closed
9 tasks
@bhajneet bhajneet added the Effort 1 Simple task (code/non-code). label May 4, 2020
@Jujhaar
Copy link
Contributor

Jujhaar commented May 16, 2020

I can take this one.

@saihaj saihaj assigned Jujhaar and unassigned saihaj May 16, 2020
@Jujhaar Jujhaar mentioned this issue May 18, 2020
Merged
Harjot1Singh pushed a commit that referenced this issue May 20, 2020
@Jujhaar
fix(frontend/controller): highlight full words in search (#536)
308ed63 
Closes #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jujhaar Jujhaar

Labels
Effort 1 Simple task (code/non-code). Impacts Some Affects the average end-user. ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
[V2] Alpha 1
Development

Successfully merging a pull request may close this issue.

fix(frontend/controller): highlight full words in search Jujhaar/desktop
4 participants
@Harjot1Singh @Jujhaar @bhajneet @saihaj