Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Full Word search #161

Merged
merged 4 commits into from
Jun 30, 2019
Merged

Add Full Word search #161

merged 4 commits into from
Jun 30, 2019

Conversation

Harjot1Singh
Copy link
Member

@Harjot1Singh Harjot1Singh commented Jun 10, 2019

Adds support for anchor based searching.

Closes #147.

@Harjot1Singh Harjot1Singh changed the base branch from master to dev June 10, 2019 00:46
@Harjot1Singh Harjot1Singh changed the title refactor(frontend): use classNames in Search Add Full Word search Jun 10, 2019
@bhajneet
Copy link
Member

bhajneet commented Jun 11, 2019

Issues with inserting accent chars. My first guess would be the interpreter for unicode/ASCII in search causes accents to be placed differently. Backspace is not following the interpreter rule. So either use pure ASCII convention or pure Unicode convention for adding/removing accents.

Example: #bi<backspace>
Example: #pRb vis you'll see the i char go behind the v and then after typing the s it will go back even another char. Then try adding more chars or backspacing from here. It will keep going back another char.
Example: #hm qy ki (unicode style) or #hm qy ik (ascii style) should be showing the result ਹਮ ਤੇ ਕਿਛੂ ਨ ਹੋਇ ਮੇਰੇ ਸ੍ਵਾਮੀ

@bhajneet
Copy link
Member

Same rules as first letters is not being applied to full words regarding K vs ^ (khakka) or a vs E (oorha).

Example: Searching #Kwlsw is not showing results for #^wlsw.

@bhajneet
Copy link
Member

bhajneet commented Jun 11, 2019

First letters never had a rule about halant. It is not common knowledge which words end with a halant character. It should be added to the exceptions like above example of #Kwlsw

Possibly add tippi and bindi to the list for last char exclusions.

Definitely add i and u to the list for last char exclusions. People cannot hear the difference between ਬੋਲ and ਬੋਲਿ or ਰਾਮ and ਰਾਮੁ

Example: Searching #jin ky B is not showing the line ਜਿਨੑ ਕੇ ਭਾਗ ਬਡੇ ਹੈ ਭਾਈ ਤਿਨੑ ਸਾਧੂ ਸੰਗਿ ਮੁਖ ਜੁਰੇ ॥

@bhajneet
Copy link
Member

Hitting the <end> key inside the search box will move the cursor to the end as expected and also highlights the last search result. Problem is hitting space after this will activate the highlighted search result instead of adding a space to the search box. Only the <enter> key should be activating the highlighted search result.

Example: #jw kw<end><space>

@bhajneet
Copy link
Member

bhajneet commented Jun 11, 2019

Vishraam causes an issue for following search ਖੂਬੁ ਖੂਬੁ ਖੂਬੁ ਖੂਬੁ ਖੂਬੁ ਤੇਰੋ ਨਾਮੁ ॥

Example: #KUbu KUbu works. #KUbu KUbu<space> fails.

@bhajneet
Copy link
Member

Incorrect highlighting. See first letter in results 3-5.

image

Copy link
Member

@bhajneet bhajneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved on the basis that the rest of the issues can be fixed over time (now separated into their own issues)

@Harjot1Singh Harjot1Singh merged commit b4e142f into dev Jun 30, 2019
@Harjot1Singh Harjot1Singh deleted the full-word branch June 30, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants