Fix compiler warnings #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…markovmodel_vertexIDToString
sporksmith
force-pushed
the
fix-warnings
branch
2 times, most recently
from
378bf2c
to
7be7b07
Compare
clang identified a bug here: ``` /__w/tgen/tgen/src/tgen-markovmodel.c:1340:25: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] ``` This probably didn't matter significantly in practice, since it'd only make a difference when the generated value rounds to exactly UINT64_MAX+1.
stevenengler
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wall) and escalate warnings to errors (-Werror)Probably most-easily reviewed one commit at a time.
I was hoping to validate that the results in the tornettools CI with these changes were exactly the same in shadow/tornettools#85, but afaict the tornettools CI still isn't deterministic. The results look plausible, though.