Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings #37

Merged
merged 11 commits into from
Jul 14, 2022
Merged

Fix compiler warnings #37

merged 11 commits into from
Jul 14, 2022

Commits on Jul 7, 2022

  1. Remove unused clusterCount variable

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d7cd394 View commit details
    Browse the repository at this point in the history

  2. Log non-null functionStr instead of possibly-null functionName

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f30e69a View commit details
    Browse the repository at this point in the history

  3. Fix calls to _tgenmarkovmodel_vertexTypeToString that should be _tgen… 

    …markovmodel_vertexIDToString
    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    456a399 View commit details
    Browse the repository at this point in the history

  4. Add cast to suppress type-mismatch warning

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    53a987f View commit details
    Browse the repository at this point in the history

  5. Add explicit note that we ignore minor-version, and suppress unused-v… 

    …ar warning
    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    39309da View commit details
    Browse the repository at this point in the history

  6. Validate version number in socks auth reply

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    32296c7 View commit details
    Browse the repository at this point in the history

  7. Suppress unused variable warning

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0b05787 View commit details
    Browse the repository at this point in the history

  8. Handle rename of igraph_i_set_attribute_table in igraph 0.9.0 

    Fixes shadow#26
    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3573c08 View commit details
    Browse the repository at this point in the history

  9. Fix incorrect comparison between double and UINT64_MAX 

    clang identified a bug here:

```
/__w/tgen/tgen/src/tgen-markovmodel.c:1340:25: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
```

This probably didn't matter significantly in practice, since it'd only
make a difference when the generated value rounds to exactly
UINT64_MAX+1.
    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    23db782 View commit details
    Browse the repository at this point in the history

  10. Remove unused cumulativeDelay

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    efb34dd View commit details
    Browse the repository at this point in the history

  11. In CI, enable all warnings, and error on warnings

    @sporksmith
    sporksmith committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6bc3662 View commit details
    Browse the repository at this point in the history