feat: port media/codecs to CMake

[cadubentzen]

• Compile media/codecs with CMake
• Compile tests for media/codecs with CMake
• Pass tests for media/codecs with CMake

Also:

• Use the same clang-format version as the CI here

Related to #1047

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[zdanek]

@cadubentzen can we go with this PR? What is blocking us?
I depend on it in two PRs :)

[cadubentzen]

@cadubentzen can we go with this PR? What is blocking us? I depend on it in two PRs :)

Hi @zdanek sorry for the delay here. At this point, only the corporate CLA is blocking it. I have already pinged folks internally to double-check it but unfortunately, it's not solved yet and I can't really speed it up :(

[zdanek]

only the corporate CLA is blocking it

that's why I'm here as an individual playing at my own rules in spare time :)

But, yeah, I do understand. I still have a lot to do in mpd.
Cheers.

[joeyparrish]

@cadubentzen, the CLA bot is happy with you, so that's good enough for me. Can you fix the copyright headers (or let me know that you don't mind me doing it)? I'm ready to merge this once that is resolved.

[cadubentzen]

@cadubentzen, the CLA bot is happy with you, so that's good enough for me. Can you fix the copyright headers (or let me know that you don't mind me doing it)? I'm ready to merge this once that is resolved.

@joeyparrish Thanks, I just fixed the copyright headers. Could you please re-trigger CI here?

[joeyparrish]

Looks like there are some build errors. At least one was a missing header. Can you please take a look?

[joeyparrish]

D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(192,17): error C2220: the following warning is treated as an error [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(192,17): warning C4459: declaration of 'kSps' hides global declaration [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(17,15): message : see declaration of 'shaka::media::`anonymous-namespace'::kSps' [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(212,17): warning C4459: declaration of 'kSps' hides global declaration [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(17,15): message : see declaration of 'shaka::media::`anonymous-namespace'::kSps' [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(233,17): warning C4459: declaration of 'kSps' hides global declaration [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(17,15): message : see declaration of 'shaka::media::`anonymous-namespace'::kSps' [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(259,17): warning C4459: declaration of 'kSps' hides global declaration [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\packager\media\codecs\h264_parser_unittest.cc(17,15): message : see declaration of 'shaka::media::`anonymous-namespace'::kSps' [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
  h265_byte_to_unit_stream_converter_unittest.cc
  h265_parser_unittest.cc
  h26x_bit_reader_unittest.cc
  hevc_decoder_configuration_record_unittest.cc
  hls_audio_util_unittest.cc
  nal_unit_to_byte_stream_converter_unittest.cc
D:\a\shaka-packager\shaka-packager\.\packager/media/formats/mp4/box_definitions_comparison.h(350,51): error C2220: the following warning is treated as an error [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\.\packager/media/formats/mp4/box_definitions_comparison.h(350,51): warning C4100: 'rhs': unreferenced formal parameter [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\.\packager/media/formats/mp4/box_definitions_comparison.h(349,51): warning C4100: 'lhs': unreferenced formal parameter [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\.\packager/media/formats/mp4/box_definitions_comparison.h(491,73): warning C4100: 'rhs': unreferenced formal parameter [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]
D:\a\shaka-packager\shaka-packager\.\packager/media/formats/mp4/box_definitions_comparison.h(491,46): warning C4100: 'lhs': unreferenced formal parameter [D:\a\shaka-packager\shaka-packager\build\packager\media\codecs\codecs_unittest.vcxproj]

[cadubentzen]

@joeyparrish I'm also now checking in parallel with the CI builds at my fork. Will ping you once the build is green there so you can retry it here 🙂

[joeyparrish]

See also #1157, which fixes the Linux release builds. (If you'll review it, I'll go ahead and merge it today.)

[cadubentzen]

@joeyparrish it should be good to go now 🙂 Got a green CI here.

[joeyparrish]

Running it again now. BTW, I am working on ways to speed up CI builds so you can have a tighter feedback loop in situations like this. It might take some time for me to get it right, but I'm working on it.