fix: Fix green screen issue on Edge with mixed content #6719
Conversation
avelad
added
type: bug
|
Incremental code coverage: 95.16% |
The latest Edge (for several years) is based on Chromium, so this shouldn't be an issue on desktops. Is there a particular platform that has a legacy version of Edge that has this problem? This is the case on our Xbox, for example. |
|
@joeyparrish unfortunately is is the issue even on current Edge Chromium when using PlayReady. |
If Widevine is used, it doesn't happen? |
|
@avelad yes, it seems we don't need this workaround when Widevine is used. |
So, this should be taken into account in the code, because right now it applies to ClearKey, PlayReady and Widevine. |
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures. Closes shaka-project#6712
For some reason on PS4, the check `val.buffer.constructor == ArrayBuffer` returns `false` when it should be `true` which causes the object cloning to return `null` instead of the array buffer. Modifying this to `val.buffer instanceof ArrayBuffer` now returns true which fixes the issue. This should work across devices. Original author: @nick-michael Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com>
MockAdManager did not define setVolume() in this one test, causing the test to throw an exception. This exception got swallowed and did not fail the test, but was noticed in the JS console during a Karma debug run.
|
@joeyparrish can you review it again? Thanks! |
On Edge, to properly play mixed content, we need to insert init segment twice for clear part - once as encrypted, and immediately again as clear. Otherwise we may encounter green screen and errors from video decoder. Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com> Co-authored-by: Nick Michael <nick-michael@users.noreply.github.com> Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
On Edge, to properly play mixed content, we need to insert init segment twice for clear part - once as encrypted, and immediately again as clear. Otherwise we may encounter green screen and errors from video decoder.